Skip to content

LG-13233: add sponsor_id to in_person_enrollments model #10759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KeithNava merged 3 commits into from
Jun 10, 2024
Merged

LG-13233: add sponsor_id to in_person_enrollments model #10759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e531aca
feat: add sponsor_id to in_person_enrollments
KeithNava Jun 4, 2024
a14c15c
changelog: Upcoming Features, In-person proofing, persist sponsor_id …
KeithNava Jun 4, 2024
4b82de0
feat: add comment for new sponsor_id field
KeithNava Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions db/primary_migrate/20240604173515_add_sponsor_id_to_in_person_enrollment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddSponsorIdToInPersonEnrollment < ActiveRecord::Migration[7.1]
def change
add_column :in_person_enrollments, :sponsor_id, :string
Copy link
Copy Markdown
Contributor

@aduth aduth Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how this column is expected to be used, but would we expect to query such that we'd want to create an index on the column?

Copy link
Copy Markdown
Contributor Author

@KeithNava KeithNava Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I actually can't think of a requirement to query this field today.... 🤔 I guess their might be a time where we'd like to see how many folks went through the Enhanced IPP flow, but I'm assuming that would be retrieved from the analytics. Let me think on this a bit more. Thanks!

Copy link
Copy Markdown
Contributor

@mitchellhenke mitchellhenke Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably lean towards no as well.

end
end
3 changes: 2 additions & 1 deletion db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema[7.1].define(version: 2024_05_31_175935) do
ActiveRecord::Schema[7.1].define(version: 2024_06_04_173515) do
# These are extensions that must be enabled in order to support this database
enable_extension "citext"
enable_extension "pg_stat_statements"
Expand Down Expand Up @@ -318,6 +318,7 @@
t.boolean "ready_for_status_check", default: false
t.datetime "notification_sent_at", comment: "The time a notification was sent"
t.datetime "last_batch_claimed_at"
t.string "sponsor_id", comment: "The identification number for USPS to recognize us and our flow (ex: Enhanced IPP)"
t.index ["profile_id"], name: "index_in_person_enrollments_on_profile_id"
t.index ["ready_for_status_check"], name: "index_in_person_enrollments_on_ready_for_status_check", where: "(ready_for_status_check = true)"
t.index ["status_check_attempted_at"], name: "index_in_person_enrollments_on_status_check_attempted_at", where: "(status = 1)"
Expand Down