Remove unused AAMVA DocAuthLog tracking#10733
Merged
Conversation
Couple changes: 1. Move log_irs_threatmetrix_fraud_check_event to VerifyInfoConcern 2. Move the logging out of `add_proofing_costs`, which we are trying to move out of VerifyInfoConcern [skip changelog]
This method does two separate things: 1. Create a FraudReviewRequest that is used to track a user's fraud review 2. Sends an event to the attempts api So this commit splits it in two.
This state_tracking_enabled flag was never turned on in prod, and as a result this entire method is not used. [skip changelog]
zachmargolis
approved these changes
May 31, 2024
| return unless IdentityConfig.store.state_tracking_enabled | ||
| doc_auth_log = DocAuthLog.find_by(user_id: current_user.id) | ||
| return unless doc_auth_log | ||
| doc_auth_log.aamva = true |
Contributor
There was a problem hiding this comment.
we could prob add aamva as an ignored column to the table if we wanted?
Contributor
There was a problem hiding this comment.
@matthinz Is the plan to follow-up with a pull request to drop the column in a separate deploy? I also noticed on Friday that the other columns in ignored_column were meant to be cleaned up last year but never were.
We aren't using this column and will want to drop it someday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supporting LG-13382
🛠 Summary of changes
The
track_aamvamethod inVerifyInfoConcernonly does anything if thestate_tracking_enabledfeature flag istrue. This flag has never been true in prod, so this is a no-op.I created LG-13461 to track completely removing the flag, but this specific method is in my way as I work on LG-13382.