Conversation
…fing job We are planning on passing the SP into the background job and using it for work in the job such as computing UUID prefixes and SP costs. First we need all of the workers to know about the new argument so we do not see `ArgumentError`s when the argument is passed to the job. This commit adds the argument [skip changelog]
zachmargolis
approved these changes
May 30, 2024
jmhooper
added a commit
that referenced
this pull request
May 30, 2024
In #10722 we added an argument for passing the service provider issuer to the `ResolutionProofingJob` evenutally this will be used for things like computing SP costs, creating `DocAuthLog` records, and determining the UUID prefix in the job. This commit starts passing the issuer to the job but does not start using it. In order to ensure that results are consistent a future commit will start reading the issue once all of the web hosts are passing it to the job. This can only be safely merged once #10722 is fully deployed. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
May 31, 2024
In #10722 we added an argument for passing the service provider issuer to the `ResolutionProofingJob` evenutally this will be used for things like computing SP costs, creating `DocAuthLog` records, and determining the UUID prefix in the job. This commit starts passing the issuer to the job but does not start using it. In order to ensure that results are consistent a future commit will start reading the issue once all of the web hosts are passing it to the job. This can only be safely merged once #10722 is fully deployed. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are planning on passing the SP into the background job and using it for work in the job such as computing UUID prefixes and SP costs. First we need all of the workers to know about the new argument so we do not see
ArgumentErrors when the argument is passed to the job. This commit adds the argument