Remove all code related to the x509_presented_hash_attribute_requested_issuers#10701
Merged
Remove all code related to the x509_presented_hash_attribute_requested_issuers#10701
Conversation
zachmargolis
approved these changes
May 28, 2024
| @@ -173,13 +173,7 @@ def x509_session? | |||
| end | |||
|
|
|||
| def x509_presented | |||
Contributor
There was a problem hiding this comment.
since we're here, and this definitely returns a boolean now, WDYT about renaming to have a ? (also good for a follow-up PR if we want to keep this one small)
Suggested change
| def x509_presented | |
| def x509_presented? |
Contributor
Author
There was a problem hiding this comment.
oh yeah actually ... i could just remove this method now and inline it since it's so smol!
… for x509:presented attr value
zachmargolis
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://gitlab.login.gov/lg-people/lg-people-appdev/protocols/backlog-fy24/-/issues/16
🛠 Summary of changes
This change is removing vestigial code left over from fixing the x509:presented attribute bug. The changes include: