LG-12555 Use 10-digit voice OTP for all IdV users #10700
Merged
Conversation
Contributor
Author
|
While I was working on this I discovered a bug that was fixed in this change. Currently the 6-character state is enabled in production until this bug fix is deployed then I will make the 10-digit state the default state for all users and this change should be mergeable. |
jmhooper
changed the title
mitchellhenke
approved these changes
May 28, 2024
zachmargolis
approved these changes
May 28, 2024
We performed an A/B test to determine which of the following so higher rates of OTP confirmation for voice OTPs: 1. 6 character alphanumeric OTPs 2. 10 digit voice OTPs Analysis of the results determined that 10 digit numeric voice OTPs outperform 6 character alphanumeric voice OTPs. This commit makes the state where 10 digit voice OTPs are sent during proofing the state for all users requesting voice OTPs during proofing. This commit also removes the code to support the A/B test. [skip changelog]
jmhooper
force-pushed
the
jmhooper-remove-10-digit-otp-test
branch
from
469eecf to
41db350
Compare
Contributor
Author
|
The bug fix is deployed and I am recycling production with the config change to enable the 10-digit state for all IdV voice users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We performed an A/B test to determine which of the following so higher rates of OTP confirmation for voice OTPs:
Analysis of the results determined that 10 digit numeric voice OTPs outperform 6 character alphanumeric voice OTPs.
This commit makes the state where 10 digit voice OTPs are sent during proofing the state for all users requesting voice OTPs during proofing. This commit also removes the code to support the A/B test.