Closed
Conversation
Contributor
Author
|
This will be ready to merge after the next deploy. The staggering of these series of changes is to prevent negative 50/50 state issues. |
Contributor
JackRyan1989
left a comment
JackRyan1989
left a comment
There was a problem hiding this comment.
Whoever merges this in will need to make sure they update the specs since they are being reworked as we speak.
|
|
||
| context 'undo/back' do | ||
| it 'sets skip_doc_auth to nil and does not redirect' do | ||
| it 'sets skip_doc_auth_from_how_to_verify to nil and does not redirect' do |
Contributor
Contributor
There was a problem hiding this comment.
That PR has been merged, so y'all should be good to go updating this test whenever.
Contributor
|
Looks like this is superseded by #11043. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13006
🛠 Summary of changes
Change
skip_doc_authdecision point to useskip_doc_auth_from_how_to_verifyWait until next deployment AFTER 24 May 2024 to merge to main.