Delete and regenerate backup codes in a single transaction#10686
Merged
mitchellhenke merged 1 commit intomainfrom May 23, 2024
Merged
Delete and regenerate backup codes in a single transaction#10686mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/backup-codes
branch
from
28402aa to
9e62ba2
Compare
aduth
approved these changes
May 23, 2024
changelog: Internal, Performance, Delete and regenerate backup codes in a single transaction
mitchellhenke
force-pushed
the
mitchellhenke/backup-codes
branch
from
9e62ba2 to
e934123
Compare
| codes = generate_new_codes | ||
|
|
||
| BackupCodeConfiguration.transaction do | ||
| @user.backup_code_configurations.destroy_all |
Contributor
There was a problem hiding this comment.
delete_all would be slightly faster than destroy_all because it doesn't run callbacks for each object? and since backup codes are like leaf nodes, there shouldn't be anything to destroy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Currently, we generate codes, delete codes, and save new codes separately. This can be kind of difficult to follow, and can be harder to safely manage backup codes. This PR simplifies the API for the BackupCodeGenerator by reducing the available operations to only
delete_and_regenerateand the verification methods.