LG-13216: Gaze into the AAMVA SOAP abyss.#10676
Merged
Conversation
The DLDV documentation PDF we have uses `nc:` to namespace things that are based on NIEM Core and `aa:` to namespace AAMVA extensions to NIEM core. Our code was using `ns1:` and `ns2:` which made it somewhat hard to follow. This commit updates template and fixture files to use `aa:` and `nc:` namespaces. It will require testing in the staging environment before deploying.
zachmargolis
approved these changes
May 22, 2024
jmhooper
approved these changes
May 22, 2024
Docs use `dldv:` for the AAMVA DLDV SOAP namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13216
🛠 Summary of changes
#10653 added two new fields to our requests to AAMVA's DLDV service: issue date and expiration date. In manual testing in our staging environment, I discovered that these fields weren't being processed by AAMVA because I used the incorrect namespace in the SOAP XML we were sending. I found it was difficult to keep track of what namespaces our code was referring to because we were labeling them differently from the AAMVA DLDV documentation.
This PR:
Here is what I just said, but in table form:
ns2:nc:ns1:aa:ns:dldv:(I only touched the verification service here--the authentication service is left as-is.)
📜 Testing Plan
I'll be executing this test after merging in the staging environment before this code goes into production:
requested_attributesfield on the result