Fix logging envs all being put in the same log group#10670
Merged
Conversation
Contributor
Author
|
I'm not actually sure if this fixes it immediately, but this will fix it when we update reviewapps cluster to have the correct cloudwatch config |
Previously all reviewapps were being put mistakenly in the same `reviewapps` cloudwatch log group. This change fixes it so they're put in cloudwatch log groups named after the reviewapp. In cloudwatch you can search for your branch to find the log groups for your reviewapp again. [skip changelog]
stephencshelton
approved these changes
May 22, 2024
Contributor
stephencshelton
left a comment
stephencshelton
left a comment
There was a problem hiding this comment.
Yeah that should fix it when it's using the new logging configuration, won't hurt anything to get this in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all reviewapps were being put mistakenly in the same
reviewappscloudwatch log group.
This change fixes it so they're put in cloudwatch log groups named after the
reviewapp.
In cloudwatch you can search for your branch to find the log groups for your
reviewapp again.