Add subresource integrity for design system initializer script#10648
Merged
Add subresource integrity for design system initializer script#10648
Conversation
changelog: Internal, Security, Add subresource integrity for design system initializer script
mitchellhenke
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Manually adds subresource integrity hash for a script contained within the design system dependency, with spec coverage to ensure it is kept in sync should the contents of the file change.
Most of our JavaScript is compiled through Webpack, where the subresource integrity hashes are computed as part of the Webpack compilation. This script is loaded directly from the
@18f/identity-design-systemNPM package, and therefore cannot take advantage of this.To ensure broad coverage of subresource integrity of all JavaScript assets loaded in critical paths, this manually assigns the integrity value. Test coverage ensures that this value is correct, in case a future update of
@18f/identity-design-systemchanges the content of the script.Alternative solutions:
📜 Testing Plan
Verify specs pass:
Verify subresource integrity is valid: