Add tests for IdentityLinker#process_ial logic#10644
Merged
Conversation
The `IdentityLinker` seems to be setting the following attributes on `ServiceProviderIdentities` for reporting purposes: - `last_ial2_authenticated_at` - `last_ial1_authenticated_at` - `verified_at` These fields seems to be queried for a number of reports and aren't used by any business logic in the IdP. This behavior is currently untested. You could remove this entire method and the test suite would still be green. This commit tests the current behavior. The current behavior does not appear to account for a number of edge cases e.g. users who sign in with IALMax or users who are signing into multiple service providers. This commit addresses none of those edge cases because I do not understand the ramifications of addressing those edge cases for our reporting. [skip changelog]
jmhooper
changed the title
IdentityLinker#process_ial logic
Sgtpluck
approved these changes
May 17, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
thanks for adding tests to this code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IdentityLinkerseems to be setting the following attributes onServiceProviderIdentitiesfor reporting purposes:last_ial2_authenticated_atlast_ial1_authenticated_atverified_atThese fields seems to be queried for a number of reports and aren't used by any business logic in the IdP.
This behavior is untested without this commit. You could remove this entire method and the test suite would still be green. This commit tests the current behavior. The current behavior does not appear to account for a number of edge cases e.g. users who sign in with IALMax or users who are signing into multiple service providers. This commit addresses none of those edge cases because I do not understand the ramifications of addressing those edge cases for our reporting.