Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module NewUniqueMonthlyUserCountsByPartner
# @param [Date] end_date iaa end date
# @return [PG::Result, Array]
def call(partner:, issuers:, start_date:, end_date:)
date_range = start_date...end_date
date_range = start_date...end_date if start_date.present? && end_date.present?

return [] if !date_range || issuers.blank?

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module UniqueMonthlyAuthCountsByIaa
# @param [Date] end_date iaa end date
# @return [PG::Result, Array]
def call(key:, issuers:, start_date:, end_date:)
date_range = start_date...end_date
date_range = start_date...end_date if start_date.present? && end_date.present?

return [] if !date_range || issuers.blank?

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
)
end

context 'with no data' do
context 'with no data no issuers' do
let(:partner_key) { 'DHS' }
let(:partner_range) { 1.year.ago..Time.zone.now }
let(:issuers) { [] }
Expand All @@ -21,6 +21,16 @@
end
end

context 'with no data no date range' do
let(:partner_key) { 'DHS' }
let(:partner_range) { nil...nil }
let(:issuers) { ['DFH', 'DFFF'] }

it 'is empty with no date range' do
expect(results).to eq([])
end
end

context 'with data' do
let(:partner_key) { 'DHS' }
let(:issuers) { [issuer1, issuer2, issuer3] }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,22 @@
expect(results).to eq([])
end

context 'missing data' do
let(:iaa_range) { nil...nil }
let(:iaa) do
{
key: key,
start_date: iaa_range.begin,
end_date: iaa_range.end,
issuers: ['DHS', 'DHF'],
}
end

it 'is empty with data no date range' do
expect(results).to eq([])
end
end

context 'with data' do
let(:iaa) do
{
Expand Down