Skip to content

LG-13220: Fix aggregated new device sign-in for expired session#10628

Merged
aduth merged 10 commits intomainfrom
aduth-lg-13220-new-device-aggregated-timeout
May 22, 2024
Merged

LG-13220: Fix aggregated new device sign-in for expired session#10628
aduth merged 10 commits intomainfrom
aduth-lg-13220-new-device-aggregated-timeout

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 14, 2024

🎫 Ticket

LG-13220

🛠 Summary of changes

Fixes an issue where new-device email notification is not sent as expected when fully authenticating after letting a first sign-in attempt expire.

This feature is only enabled in local development, so this is not a bug affecting production.

📜 Testing Plan

  1. In a private browser, go to http://localhost:3000
  2. Sign in successfully with email and password (do not complete MFA)
  3. Wait until your sign-in session times out (~15minutes, you'll see an alert "We cleared your information due to inactivity" and be returned to sign-in
  4. Sign in again and complete MFA

Before: The second email is not sent after completing MFA.
After: Two emails are sent: One for the initial timeout of the notification window listing the email and password submission, and a second after completing MFA.

@aduth aduth force-pushed the aduth-lg-13220-new-device-aggregated-timeout branch from a0a5e60 to 825c964 Compare May 17, 2024 15:39
@aduth aduth marked this pull request as ready for review May 17, 2024 18:06
@aduth aduth requested a review from a team May 17, 2024 18:06
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aduth aduth force-pushed the aduth-lg-13220-new-device-aggregated-timeout branch from 825c964 to c1dae92 Compare May 21, 2024 12:48
@aduth aduth merged commit 43ed171 into main May 22, 2024
@aduth aduth deleted the aduth-lg-13220-new-device-aggregated-timeout branch May 22, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants