Stop creating ServiceProviderRequest records with unused fields#10626
Merged
Stop creating ServiceProviderRequest records with unused fields#10626
ServiceProviderRequest records with unused fields#10626Conversation
Previous commits retired the following fields on the `ServiceProviderRequest` model: - ial - aal - biometric_comparison_required These fields were left behind because removing them leads to issues during deploys when old and new versions of the code are running. The `ServiceProviderRequest` model has default values for these fields. This means that we can stop creating records with these fields. However, we use the hash that is written to redis to create `ServiceProviderRequest`s. This means that if we remove the keyword arguments for these fields we will encounter a `ArgumentError` when we try to create a record on a new host with a hash written by an old host. [skip changelog]
Contributor
Author
|
The code that reads from |
zachmargolis
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous commits retired the following fields on the
ServiceProviderRequestmodel:ialaalbiometric_comparison_requiredThese fields were left behind because removing them leads to issues during deploys when old and new versions of the code are running at the same time.
The
ServiceProviderRequestmodel has default values for these fields. This means that we can stop creating records with these fields and the defaults will be used. However, we use the hash that is written to redis is converted into keyword args to createServiceProviderRequests. This means that if we remove the keys for these fields we will encounter aArgumentErrorwhen we try to create a record on a new host with a hash written by an old host. This commit leaves them behind and a follow-up will be needed to remove them.