Skip to content

Remove AAL2 lines from Authentication Funnel report #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeremy1026 merged 1 commit into from
May 14, 2024
Merged

Remove AAL2 lines from Authentication Funnel report #10622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions lib/reporting/authentication_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,19 +201,6 @@ def funnel_metrics_table
denominator: email_confirmation,
),
],
[
'AAL2 Authentication Requests from Partner',
oidc_auth_request,
format_as_percent(numerator: oidc_auth_request, denominator: oidc_auth_request),
],
[
'AAL2 Authenticated Requests',
sp_redirect_initiated_after_oidc,
format_as_percent(
numerator: sp_redirect_initiated_after_oidc,
denominator: oidc_auth_request,
),
],
]
end

Expand Down
2 changes: 0 additions & 2 deletions spec/jobs/reports/authentication_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
['New Users Completed IAL1 Password Setup', '85', '85%'],
['New Users Completed IAL1 MFA', '80', '80%'],
['New IAL1 Users Consented to Partner', '75', '75%'],
['AAL2 Authentication Requests from Partner', '12', '12%'],
['AAL2 Authenticated Requests', '50', '50%'],
],
),
]
Expand Down
2 changes: 0 additions & 2 deletions spec/lib/reporting/authentication_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ def expected_tables(strings: false)
['New Users Completed IAL1 Password Setup', strings ? '3' : 3, '75.0%'],
['New Users Completed IAL1 MFA', strings ? '2' : 2, '50.0%'],
['New IAL1 Users Consented to Partner', strings ? '1' : 1, '25.0%'],
['AAL2 Authentication Requests from Partner', strings ? '5' : 5, '100.0%'],
['AAL2 Authenticated Requests', strings ? '2' : 2, '40.0%'],
],
]
end
Expand Down