Agnes/lg 13018 billing report v2#10613
Merged
samathad2023 merged 22 commits intomainfrom May 13, 2024
Merged
Conversation
changelog: Internal, Reporting,update specs and unique partner helper
changelog: Internal, Reporting removed unwanted updates
…ents and clean up before final commit
changelog: Internal, Reporting, new billing_report_v2 with partner
changelog: Internal, Reporting, Add Partner to combined_invoice_supplement_report
app/services/db/monthly_sp_auth_count/new_unique_monthly_user_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
spec/services/db/monthly_sp_auth_count/new_unique_monthly_user_counts_by_partner_spec.rb
Outdated
Show resolved
Hide resolved
ThatSpaceGuy
approved these changes
May 13, 2024
Contributor
ThatSpaceGuy
left a comment
ThatSpaceGuy
left a comment
There was a problem hiding this comment.
Thanks for all the hard work, @samathad2023 and @colter-nattrass!
zachmargolis
approved these changes
May 13, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! one last comment update but otherwise good to go
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13018
🛠 Summary of changes
Created new combined invoice report v2 with partner details along with profile age.This new report will help login.gov to see partner billing details.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.