Conversation
aduth
reviewed
May 13, 2024
…ed language Overhauled the letter enqueued page language per UX recommendations and added simplified Chinese translations. Co-authored by: Andrew Duthie <andrew.duthie@gsa.gov>
`LetterEnqueuedPresenter#pii_from_user_session` now defaults unused parameters to nil.
jmax-gsa
force-pushed
the
jmax/LG-13296-update-chinese-translations-for-letter-on-the-way
branch
from
45bdf92 to
6c26972
Compare
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
aduth
reviewed
May 15, 2024
Per review comment by Andrew Duthie <andrew.duthie@gsa.gov>
jmhooper
reviewed
May 15, 2024
artfulaction
suggested changes
May 15, 2024
Contributor
artfulaction
left a comment
artfulaction
left a comment
There was a problem hiding this comment.
French screenshot has a missing/misplaced period at the last sentence. Otherwise the screenshots look good to me!
Updated the places where we look for Pii to display per Hooper's comment.
jmhooper
approved these changes
May 16, 2024
artfulaction
approved these changes
May 16, 2024
jmax-gsa
deleted the
jmax/LG-13296-update-chinese-translations-for-letter-on-the-way
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13296
🛠 Summary of changes
Overhauled the letter enqueued page language per UX recommendations and added simplified Chinese translations.
Co-authored by: Andrew Duthie andrew.duthie@gsa.gov
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
letter_enqueued_presenter_spec.rbprovides adequate coverage for the presenter.👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
English:
Spanish:
French:
Simplified Chinese: