Skip to content

LG-12706: Include user_id in piv_cac_login event#10584

Merged
aduth merged 2 commits intomainfrom
aduth-lg-12706-piv-login-user-id
May 14, 2024
Merged

LG-12706: Include user_id in piv_cac_login event#10584
aduth merged 2 commits intomainfrom
aduth-lg-12706-piv-login-user-id

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 10, 2024

🎫 Ticket

LG-12706

🛠 Summary of changes

Updates logging of piv_cac_login to ensure that a non-nil user_id is included in the logged result.

📜 Testing Plan

  1. Run EVENT_NAME=piv_cac_login make watch_events in a separate terminal process to the IdP
  2. Go to http://localhost:3000
  3. Click "Sign in with your government employee ID"
  4. Sign in with PIV
  5. Observe log entry "piv_cac_login" has a user_id for the user which logged in

changelog: Internal, Analytics, Include user_id in piv_cac_login event
@aduth aduth requested a review from a team May 10, 2024 13:46
@aduth aduth marked this pull request as draft May 10, 2024 20:34
@aduth aduth marked this pull request as ready for review May 14, 2024 12:46
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-14 at 8 55 30 AM LGTM 👍

@aduth aduth merged commit ff97682 into main May 14, 2024
@aduth aduth deleted the aduth-lg-12706-piv-login-user-id branch May 14, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants