Create a report of integrations using deprecated LOA ACR values#10562
Create a report of integrations using deprecated LOA ACR values#10562
Conversation
vrajmohan
force-pushed
the
loa-requests-report
branch
from
6dd13b2 to
5306e17
Compare
See https://gitlab.login.gov/lg-people/lg-people-appdev/protocols/common/-/issues/2 **Why**: - We would like to like know how many service providers are still using the deprecated LOA ACR values. **How**: - Using a similar pattern to other reports, query our CloudWatch logs to report from the analytics events log. changelog: Internal, Reporting, Create LOA ACR requests report
vrajmohan
force-pushed
the
loa-requests-report
branch
from
5306e17 to
553084e
Compare
Sgtpluck
left a comment
Sgtpluck
left a comment
There was a problem hiding this comment.
a small question but looks good to me
| to: time_range.end, | ||
| ). | ||
| map { |slice| slice['issuer'] }. | ||
| uniq |
There was a problem hiding this comment.
[question] since you're running dedup in the query, is this necessary?
There was a problem hiding this comment.
It is needed because the same issuer may be present in different time slices; the dedup would only make them unique within a slice.
| from: time_range.begin, | ||
| to: time_range.end, | ||
| ). | ||
| map { |slice| slice['issuer'] }. |
There was a problem hiding this comment.
we don't need to fix this in this PR, but i have been having a hard time with the word slice in this context (and other places it's used in maps) especially since we have a different slice var on the instance. we should probably go back and change the references to something that make more sense in the local context, but it's not blocking.
There was a problem hiding this comment.
I inherited the naming from mfa_report.rb. The fetched results from CloudWatch are row slices, ie they could be a full row from the original query (if the time slice and the period coincided) or they could be a row split into time slices. We could use row or row_slice. I don't like row as it hides the fact that it could have been split up. I would prefer row_slice, or leaving it as slice.
There was a problem hiding this comment.
i understand why slice was used. i still think reusing the variable slice can be confusing at a glance.
2 participants
🎫 Ticket
Link to the relevant ticket: https://gitlab.login.gov/lg-people/lg-people-appdev/protocols/common/-/issues/2
🛠 Summary of changes
Created a report of integrations using deprecated LOA ACR values.
📜 Testing Plan