LG-13132 Adds property to SP redirect initiated event#10560

Merged

kevinsmaster5 merged 21 commits intomainfrom

kmas-lg-13132-sp-redirect-duration

May 14, 2024

Commits on May 14, 2024

changelog: Internal, Analytics, Adds property to SP redirect initiated event
kevinsmaster5
committed
update controllers to account for legit nil values at login page visit (dual browsers, etc.) revise other tests to include sign_in_duration
kevinsmaster5
committed
change to duration tracking to allow for nil. fix redundant integer management. refactored duration calculation as a separate method in shared module
kevinsmaster5
committed
remove hard-coded nil value
kevinsmaster5
committed
rebase merge conflict. fix mis-inserted function in auth count concern, leverage helper method
kevinsmaster5
committed
wrap time-based expect blocks in freeze_time. at least one spec was failing because of time-weirdness
kevinsmaster5
committed
reframe freeze block
kevinsmaster5
committed
add travel to expected time elapsed
kevinsmaster5
committed
add freeze and travel to to test
kevinsmaster5
committed
correct use of freeze_time and add travel to to tests
kevinsmaster5
committed
put better control over time in idp controller test
kevinsmaster5
committed
tracking saml_idp as nil seems more appropriate with the tests there. removing session setting from session_helper to try changing that back
kevinsmaster5
committed
move sign_in_duration method to its own concern
kevinsmaster5
committed
rename duration method, leverage around -> do for better freeze_time control
kevinsmaster5
committed
add unit test for SignInDurationConcern
kevinsmaster5
committed
improve concern spec with time freeze and clarify test context
kevinsmaster5
committed
make use of time as string consistent
kevinsmaster5
committed
remove leftover code comments
kevinsmaster5
committed
adjust time freeze
kevinsmaster5
committed
create more precision by rounding instead of converting to i
kevinsmaster5
committed
change sign in duration output to a floating number
kevinsmaster5
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-13132 Adds property to SP redirect initiated event#10560

LG-13132 Adds property to SP redirect initiated event#10560
kevinsmaster5 merged 21 commits intomainfrom
kmas-lg-13132-sp-redirect-duration

Commits on May 14, 2024

changelog: Internal, Analytics, Adds property to SP redirect initiated event

update controllers to account for legit nil values at login page visit (dual browsers, etc.) revise other tests to include sign_in_duration

change to duration tracking to allow for nil. fix redundant integer management. refactored duration calculation as a separate method in shared module

remove hard-coded nil value

rebase merge conflict. fix mis-inserted function in auth count concern, leverage helper method

wrap time-based expect blocks in freeze_time. at least one spec was failing because of time-weirdness

reframe freeze block

add travel to expected time elapsed

add freeze and travel to to test

correct use of freeze_time and add travel to to tests

put better control over time in idp controller test

tracking saml_idp as nil seems more appropriate with the tests there. removing session setting from session_helper to try changing that back

move sign_in_duration method to its own concern

rename duration method, leverage around -> do for better freeze_time control

add unit test for SignInDurationConcern

improve concern spec with time freeze and clarify test context

make use of time as string consistent

remove leftover code comments

adjust time freeze

create more precision by rounding instead of converting to i

change sign in duration output to a floating number