Agnes/lg 13013 billing report multiple year helper#10556
Merged
ThatSpaceGuy merged 21 commits intomainfrom May 13, 2024
Merged
Conversation
zachmargolis
reviewed
May 3, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 3, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 3, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 7, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 7, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 7, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 7, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 9, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
zachmargolis
reviewed
May 9, 2024
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Show resolved
Hide resolved
spec/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner_spec.rb
Outdated
Show resolved
Hide resolved
changelog: Internal, Reporting,update specs and unique partner helper
changelog: Internal, Reporting removed unwanted updates
…ents and clean up before final commit
…ts_by_partner.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…ts_by_partner.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
ThatSpaceGuy
force-pushed
the
agnes/lg-13013-billing_report_multiple_year_helper
branch
from
48cd2bc to
8642c31
Compare
ThatSpaceGuy
approved these changes
May 13, 2024
zachmargolis
approved these changes
May 13, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! some small comments but this is ready to go! Nice work
app/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner.rb
Outdated
Show resolved
Hide resolved
spec/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner_spec.rb
Outdated
Show resolved
Hide resolved
spec/services/db/monthly_sp_auth_count/unique_monthly_auth_counts_by_partner_spec.rb
Outdated
Show resolved
Hide resolved
ThatSpaceGuy
deleted the
agnes/lg-13013-billing_report_multiple_year_helper
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13013
🛠 Summary of changes
Added new helper for unique user auth counts by partner.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.