Skip to content

Remove unused method verification_method_choice #10553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
May 3, 2024
Merged

Remove unused method verification_method_choice #10553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/decorators/null_service_provider_session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ def new_session_heading
I18n.t('headings.sign_in_without_sp')
end

def verification_method_choice
I18n.t('idv.messages.select_verification_without_sp')
end

def cancel_link_url
view_context.root_url
end
Expand Down
4 changes: 0 additions & 4 deletions app/decorators/service_provider_session.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ def new_session_heading
I18n.t('headings.sign_in_with_sp', sp: sp_name)
end

def verification_method_choice
I18n.t('idv.messages.select_verification_with_sp', sp_name: sp_name)
end

def requested_attributes
(sp_session[:requested_attributes] || service_provider_request.requested_attributes).sort
end
Expand Down
4 changes: 0 additions & 4 deletions config/locales/idv/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,6 @@ en:
- Based in the United States (including U.S. territories)
- Your primary number (the one you use the most often)
return_to_profile: '‹ Return to your %{app_name} profile'
select_verification_with_sp: To protect you from identity fraud, we will contact
you to confirm that this %{sp_name} account is legitimate.
select_verification_without_sp: To protect you from identity fraud, we will
contact you to confirm that this account is legitimate.
sessions:
enter_password_message: When you re-enter your password, %{app_name} will
protect the information you’ve given us, so that only you can access
Expand Down
5 changes: 0 additions & 5 deletions config/locales/idv/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,6 @@ es:
- Con base en Estados Unidos (incluidos los territorios de EE.UU.)
- Su número principal (el que utiliza con más frecuencia)
return_to_profile: '‹ Vuelva a su perfil de %{app_name}'
select_verification_with_sp: Para protegerle contra el fraude de identidad,
contactaremos con usted para confirmar que esta cuenta de %{sp_name} es
legítima.
select_verification_without_sp: Para protegerle contra el fraude de identidad,
contactaremos con usted para confirmar que esta cuenta es legítima.
sessions:
enter_password_message: Cuando vuelva a ingresar su contraseña, %{app_name}
protegerá la información que nos dio, para que solo usted pueda
Expand Down
6 changes: 0 additions & 6 deletions config/locales/idv/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,6 @@ fr:
- Basé aux Etats-Unis (y compris les territoires américains)
- Votre numéro principal (celui que vous utilisez le plus souvent)
return_to_profile: '‹ Revenir à votre profil %{app_name}'
select_verification_with_sp: Afin de vous protéger contre l’usurpation
d’identité, nous vous contacterons pour confirmer que ce compte
%{sp_name} est légitime.
select_verification_without_sp: Afin de vous protéger contre l’usurpation
d’identité, nous vous contacterons pour confirmer que ce compte est
légitime.
sessions:
enter_password_message: Lorsque vous ressaisirez votre mot de passe, %{app_name}
protégera les informations que vous nous aurez données pour que vous
Expand Down
2 changes: 0 additions & 2 deletions config/locales/idv/zh.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,6 @@ zh:
- 美国的（包括美国属地）
- 你的主要号码（你最常用的）
return_to_profile: '‹ 返回你的 %{app_name} 用户资料'
select_verification_with_sp: 为了保护你不受身份欺诈，我们会联系你确认该 %{sp_name} 账户是真实的。
select_verification_without_sp: 为了保护你不受身份欺诈，我们会联系你确认该账户是真实的。
sessions:
enter_password_message: 你重新输入密码时， %{app_name} 会保护你给我们的信息，这样只有你能访问这些信息。
no_pii: 测试站点 - 请勿使用真实个人信息（仅为演示目的） - 测试站点
Expand Down
8 changes: 0 additions & 8 deletions spec/decorators/null_service_provider_session_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@
end
end

describe '#verification_method_choice' do
it 'returns the correct string' do
expect(subject.verification_method_choice).to eq(
I18n.t('idv.messages.select_verification_without_sp'),
)
end
end

describe '#sp_logo' do
it 'returns nil' do
expect(subject.sp_logo).to be_nil
Expand Down
8 changes: 0 additions & 8 deletions spec/decorators/service_provider_session_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@
end
end

describe '#verification_method_choice' do
it 'returns the correct string' do
expect(subject.verification_method_choice).to eq(
I18n.t('idv.messages.select_verification_with_sp', sp_name: sp_name),
)
end
end

describe '#sp_alert' do
context 'sp has custom alert' do
it 'uses the custom template' do
Expand Down