-
Notifications
You must be signed in to change notification settings - Fork 166
LG-12693 How to verify biometric design updates #10524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gina-yamada
merged 32 commits into
main
from
yamada/lg-12693-how-to-verify-biometric-design-content-updates
May 14, 2024
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
a8937e4
add mobile phone icon
gina-yamada 512a6ca
Update translations for how to verify view
gina-yamada 6f23a3c
Add translations for how to verify button
gina-yamada 477a31e
Added instance var to selectively display content
gina-yamada b5f92c2
fix lint issues
gina-yamada a2e09c5
specs for conditional logic on how to verify
gina-yamada be5e775
fix lint errors
gina-yamada 5c5db1d
fix linter errors
gina-yamada df75690
Create how_to_verify presenter for condi rendering
gina-yamada e21f1e9
Update specs to look for specific button
gina-yamada 6bd715a
fix linter errors
gina-yamada c650f83
fix lint errors
gina-yamada 11ab0eb
Clean up unused var, add extra line
gina-yamada 6109bed
Merge branch 'main' of github.com:18F/identity-idp into yamada/lg-126…
gina-yamada df348e1
changelog: Upcoming Features, Biometrics, Modified UX/Content on How …
gina-yamada a1eece6
pulled in main, resolved conflicts
gina-yamada fc062d1
removed extra blank line
gina-yamada 5815449
remove extra blank line
gina-yamada b549b46
Add margin above tag
gina-yamada c99944e
add verify_online_instruction translation back in
gina-yamada abdc515
Updated Chinese translation
gina-yamada abc13c8
Add period in translation
gina-yamada 3bf4b95
Merge branch 'main' of github.com:18F/identity-idp into yamada/lg-126…
gina-yamada f1f9417
Delete dup verify_online_instruction in chinese
gina-yamada 4bc8b8d
pulled in main, ran yml_fix_merge_conflicts script
gina-yamada cbea414
delete doc_auth and forms folder
gina-yamada 418185c
restore eng translations
gina-yamada 56651fc
restore translation files
gina-yamada 4461398
restore translations
gina-yamada 0568978
Add class to icon
gina-yamada 3a48a98
Merge branch 'main' of github.com:18F/identity-idp into yamada/lg-126…
gina-yamada e69e1f4
Merge branch 'main' of github.com:18F/identity-idp into yamada/lg-126…
gina-yamada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class Idv::HowToVerifyPresenter | ||
| include ActionView::Helpers::TagHelper | ||
| include ActionView::Helpers::TranslationHelper | ||
|
|
||
| attr_reader :selfie_required | ||
|
|
||
| def initialize(selfie_check_required:) | ||
| @selfie_required = selfie_check_required | ||
| end | ||
|
|
||
| def how_to_verify_info | ||
|
gina-yamada marked this conversation as resolved.
|
||
| if selfie_required | ||
| t('doc_auth.info.how_to_verify_selfie') | ||
| else | ||
| t('doc_auth.info.how_to_verify') | ||
| end | ||
| end | ||
|
|
||
| def asset_url | ||
| if selfie_required | ||
| 'idv/mobile-phone-icon.svg' | ||
| else | ||
| 'idv/remote.svg' | ||
| end | ||
| end | ||
|
|
||
| def alt_text | ||
| if selfie_required | ||
| t('image_description.phone_icon') | ||
| else | ||
| t('image_description.laptop_and_phone') | ||
| end | ||
| end | ||
|
|
||
| def verify_online_text | ||
| if selfie_required | ||
| t('doc_auth.headings.verify_online_selfie') | ||
| else | ||
| t('doc_auth.headings.verify_online') | ||
| end | ||
| end | ||
|
|
||
| def verify_online_instruction | ||
| if selfie_required | ||
| t('doc_auth.info.verify_online_instruction_selfie') | ||
| else | ||
| t('doc_auth.info.verify_online_instruction') | ||
| end | ||
| end | ||
|
|
||
| def verify_online_description | ||
| if selfie_required | ||
| t('doc_auth.info.verify_online_description_selfie') | ||
| else | ||
| t('doc_auth.info.verify_online_description') | ||
| end | ||
| end | ||
|
|
||
| def submit | ||
| if selfie_required | ||
| t('forms.buttons.continue_remote_selfie') | ||
| else | ||
| t('forms.buttons.continue_remote') | ||
| end | ||
| end | ||
|
|
||
| def post_office_instruction | ||
| if selfie_required | ||
| t('doc_auth.info.verify_at_post_office_instruction_selfie') | ||
| else | ||
| t('doc_auth.info.verify_at_post_office_instruction') | ||
| end | ||
| end | ||
|
|
||
| def post_office_description | ||
| if selfie_required | ||
| t('doc_auth.info.verify_at_post_office_description_selfie') | ||
| else | ||
| t('doc_auth.info.verify_at_post_office_description') | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.