Remove Lint Exceptions: Prop Type Exceptions

.eslintrc

@@ -85,16 +85,9 @@
     },
     {
       "files": [
-        "app/javascript/packages/address-search/components/in-person-locations.spec.tsx",
-        "app/javascript/packages/components/spinner-dots.jsx",
         "app/javascript/packages/document-capture/components/acuant-capture.tsx",
-        "app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.jsx",
-        "app/javascript/packages/document-capture/components/document-side-acuant-capture.jsx",
         "app/javascript/packages/document-capture/components/file-image.jsx",
         "app/javascript/packages/document-capture/components/file-input.tsx",
-        "app/javascript/packages/document-capture/components/in-person-location-full-address-entry-post-office-search-step.tsx",
-        "app/javascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx",
-        "app/javascript/packages/document-capture/components/in-person-prepare-step.tsx",
         "app/javascript/packages/document-capture/components/submission-interstitial.jsx",
         "app/javascript/packages/document-capture/components/submission.jsx",
         "spec/javascript/packages/document-capture/context/failed-capture-attempts-spec.jsx",

app/javascript/packages/address-search/components/in-person-locations.spec.tsx

@@ -5,7 +5,7 @@ import sinon from 'sinon';
 import type { FormattedLocation } from './in-person-locations';
 import InPersonLocations from './in-person-locations';
 
-function NoLocationsViewMock({ address }) {
+function NoLocationsViewMock({ address }: { address: string }) {
   return (
     <div data-testid="no-results-found">
       <p>No PO found</p>

app/javascript/packages/components/spinner-dots.jsx → app/javascript/packages/components/spinner-dots.tsx

@@ -1,15 +1,14 @@
-/**
- * @typedef SpinnerDotsProps
- *
- * @prop {boolean=} isCentered Whether to absolutely-position the element at its container's center.
- * Defaults to false.
- * @prop {string=} className Optional class name.
- */
+interface SpinnerDotsProps {
+  // Optional whether to absolutely-position the element at its container's center. Defaults to false.
+  isCentered?: boolean;
+  // Optional class name.
+  className?: string;
+}
 
 /**
  * @param {SpinnerDotsProps} props
  */
-function SpinnerDots({ isCentered, className }) {
+function SpinnerDots({ isCentered, className }: SpinnerDotsProps) {
   const classes = ['spinner-dots', isCentered && 'spinner-dots--centered', className]
     .filter(Boolean)
     .join(' ');

app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.jsx → app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.tsx

@@ -15,7 +15,15 @@ function LoadingSpinner() {
   );
 }
 
-function AcuantSelfieCaptureCanvas({ imageCaptureText, onSelfieCaptureClosed }) {
+interface AcuantSelfieCaptureCanvasProps {
+  imageCaptureText: string;
+  onSelfieCaptureClosed: () => void;
+}
+
+function AcuantSelfieCaptureCanvas({
+  imageCaptureText,
+  onSelfieCaptureClosed,
+}: AcuantSelfieCaptureCanvasProps) {
   const { isReady } = useContext(AcuantContext);
   const { t } = useI18n();
   // The Acuant SDK script AcuantPassiveLiveness attaches to whatever element has

app/javascript/packages/document-capture/components/in-person-location-full-address-entry-post-office-search-step.spec.tsx

@@ -39,7 +39,7 @@ const USPS_RESPONSE = [
 const DEFAULT_PROPS = {
   toPreviousStep() {},
   onChange() {},
-  registerField() {},
+  registerField: (_string) => undefined,
 };
 
 describe('InPersonLocationFullAddressEntryPostOfficeSearchStep', () => {

app/javascript/packages/document-capture/components/in-person-location-full-address-entry-post-office-search-step.tsx

@@ -3,16 +3,23 @@ import { request } from '@18f/identity-request';
 import { forceRedirect } from '@18f/identity-url';
 import { FullAddressSearch, transformKeys, snakeCase } from '@18f/identity-address-search';
 import type { FormattedLocation } from '@18f/identity-address-search/types';
+import type { RegisterFieldCallback } from '@18f/identity-form-steps';
 import BackButton from './back-button';
 import AnalyticsContext from '../context/analytics';
 import { InPersonContext } from '../context';
 import UploadContext from '../context/upload';
 
+interface InPersonLocationFullAddressEntryPostOfficeSearchStepProps {
+  onChange: ({ selectedLocationAddress }: { selectedLocationAddress: string }) => void;
+  toPreviousStep: () => void;
+  registerField: RegisterFieldCallback;
+}
+
 function InPersonLocationFullAddressEntryPostOfficeSearchStep({
   onChange,
   toPreviousStep,
   registerField,
-}) {
+}: InPersonLocationFullAddressEntryPostOfficeSearchStepProps) {
   const { inPersonURL, locationsURL, usStatesTerritories } = useContext(InPersonContext);
   const [inProgress, setInProgress] = useState<boolean>(false);
   const [autoSubmit, setAutoSubmit] = useState<boolean>(false);

app/javascript/packages/document-capture/components/in-person-location-post-office-search-step.spec.tsx

@@ -54,7 +54,7 @@ const DEFAULT_PROPS = {
   toPreviousStep() {},
   onChange() {},
   value: {},
-  registerField() {},
+  registerField: (_string) => undefined,
 };
 
 describe('InPersonLocationPostOfficeSearchStep', () => {

app/javascript/packages/document-capture/components/in-person-location-post-office-search-step.tsx

@@ -3,12 +3,23 @@ import { request } from '@18f/identity-request';
 import { forceRedirect } from '@18f/identity-url';
 import AddressSearch, { transformKeys, snakeCase } from '@18f/identity-address-search';
 import type { FormattedLocation } from '@18f/identity-address-search/types';
+import type { RegisterFieldCallback } from '@18f/identity-form-steps';
 import BackButton from './back-button';
 import AnalyticsContext from '../context/analytics';
 import { InPersonContext } from '../context';
 import UploadContext from '../context/upload';
 
-function InPersonLocationPostOfficeSearchStep({ onChange, toPreviousStep, registerField }) {
+interface InPersonLocationPostOfficeSearchStepProps {
+  onChange: ({ selectedLocationAddress }: { selectedLocationAddress: string }) => void;
+  toPreviousStep: () => void;
+  registerField: RegisterFieldCallback;
+}
+
+function InPersonLocationPostOfficeSearchStep({
+  onChange,
+  toPreviousStep,
+  registerField,
+}: InPersonLocationPostOfficeSearchStepProps) {
   const { inPersonURL, locationsURL, addressSearchURL } = useContext(InPersonContext);
   const [inProgress, setInProgress] = useState<boolean>(false);
   const [autoSubmit, setAutoSubmit] = useState<boolean>(false);

app/javascript/packages/document-capture/components/in-person-prepare-step.tsx

@@ -11,7 +11,7 @@ import InPersonTroubleshootingOptions from './in-person-troubleshooting-options'
 import { InPersonContext } from '../context';
 import InPersonOutageAlert from './in-person-outage-alert';
 
-function InPersonPrepareStep({ toPreviousStep }) {
+function InPersonPrepareStep({ toPreviousStep }: { toPreviousStep: () => void }) {
   const { t } = useI18n();
   const { flowPath } = useContext(UploadContext);
   const { securityAndPrivacyHowItWorksURL } = useContext(MarketingSiteContext);

scripts/enforce-typescript-files.mjs

@@ -14,7 +14,6 @@ const LEGACY_FILE_EXCEPTIONS = [
   'app/javascript/packages/device/index.js',
   'app/javascript/packages/document-capture/index.js',
   'app/javascript/packages/document-capture/components/acuant-capture-canvas.jsx',
-  'app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.jsx',
   'app/javascript/packages/document-capture/components/callback-on-mount.jsx',
   'app/javascript/packages/document-capture/components/file-image.jsx',
   'app/javascript/packages/document-capture/components/submission-interstitial.jsx',