Skip to content
Merged
3 changes: 1 addition & 2 deletions config/locales/doc_auth/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ en:
network_error: We are having technical difficulties on our end. Please try to
submit your images again later.
no_liveness: Try taking new pictures.
selfie_failure: Try taking your photos again. Make sure all of your photos are
clear and in focus.
selfie_failure: We couldn’t verify the photo of yourself. Try taking a new picture.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellular (or anyone) I'm not seeing translations? I'll keep looking.

Copy link

@kellular kellular Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charleyf They might have been accidentally removed the last time we worked on this in-line error, I can't recall. But here are the DOS translations:

Spanish: No pudimos verificar su foto. Intente tomar una nueva foto.
French: Nous n’avons pas pu vérifier votre photo. Essayez de prendre une nouvelle photo.
Chinese Simplified (are we supposed to add these now?): 我们无法验证你自己的照片。请重拍一张。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added those, I don't see anywhere to put the simplified Chinese yet. I would expect a file like doc_auth/zh-CN.yml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charleyf , it's zh.yml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kellular yes, please include Chinese translations going forward

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the chinese translation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charleyf thanks for adding the chinese translation - could you please add a screenshot to the PR so I can submit this for DOS LQA approval?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded a screenshot to the PR description.

selfie_failure_help_link_text: Review more tips for taking clear photos
glare:
failed_short: Image has glare, please try again.
Expand Down
5 changes: 2 additions & 3 deletions config/locales/doc_auth/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ es:
network_error: Estamos teniendo problemas técnicos por nuestra parte. Intente
enviar sus imágenes de nuevo más tarde.
no_liveness: Intente tomar nuevas fotografías.
selfie_failure: Intente tomar de nuevo sus fotos. Asegúrese de que sus fotos
estén claras y enfocadas.
selfie_failure: No pudimos verificar su foto. Intente tomar una nueva foto.
selfie_failure_help_link_text: Consulte más consejos para tomar fotos claras
glare:
failed_short: Hay reflejos en la imagen, por favor inténtelo de nuevo.
Expand Down Expand Up @@ -190,7 +189,7 @@ es:
verify_at_post_office: Verifique su identidad en una oficina de correos
verify_identity: Verifique su identidad
verify_online: Verifique su identidad en línea
welcome: 'Verifiquemos su identidad para%{sp_name}'
welcome: 'Verifiquemos su identidad para %{sp_name}'
hybrid_flow_warning:
explanation_html: Usted está utilizando <strong>%{app_name}</strong> para
verificar su identidad y acceder a
Expand Down
4 changes: 2 additions & 2 deletions config/locales/doc_auth/fr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ fr:
network_error: Nous avons des difficultés techniques de notre côté. Veuillez
essayer de soumettre à nouveau vos images plus tard.
no_liveness: Essayez de prendre de nouvelles photos.
selfie_failure: Essayez de prendre de nouvelles photos de vous-même. Veillez à
ce que toutes vos photos soient claires et nettes.
selfie_failure: Nous n’avons pas pu vérifier votre photo. Essayez de prendre une
nouvelle photo.
selfie_failure_help_link_text: Consultez plus de conseils pour prendre des photos claires
glare:
failed_short: L’image a des reflets, veuillez réessayer.
Expand Down
3 changes: 1 addition & 2 deletions config/locales/doc_auth/zh.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ zh:
multiple_front_id_failures: 我们无法验证你身份证件的正面。尝试重拍一张。
network_error: 我们这边有技术困难。请稍后再提交你的图像。
no_liveness: 尝试重拍。
selfie_failure: Try taking your photos again. Make sure all of your photos are
clear and in focus.
selfie_failure: 我们无法验证你自己的照片。请重拍一张。
selfie_failure_help_link_text: Review more tips for taking clear photos
glare:
failed_short: 图像有炫光,请再试一次。
Expand Down
23 changes: 23 additions & 0 deletions spec/features/idv/doc_auth/document_capture_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,10 @@
expect(page).to have_content(body_error_message)

click_try_again

selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).to have_content(selfie_inline_error_message)

expect(page).to have_current_path(idv_document_capture_path)

# inline error to be fixed in lg-12999
Expand Down Expand Up @@ -385,6 +389,8 @@

inline_error_message = strip_tags(t('doc_auth.errors.dpi.failed_short'))
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).not_to have_content(selfie_inline_error_message)

# when there are both doc auth errors and face match errors

Expand Down Expand Up @@ -414,6 +420,8 @@

inline_error_message = strip_tags(t('doc_auth.errors.dpi.failed_short'))
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).not_to have_content(selfie_inline_error_message)

# when doc auth result and liveness pass but face match fails

Expand Down Expand Up @@ -445,6 +453,8 @@
t('doc_auth.errors.general.multiple_front_id_failures'),
)
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).to have_content(selfie_inline_error_message)

# when there is a doc auth error on one side of the ID and face match errors

Expand Down Expand Up @@ -474,6 +484,8 @@

inline_error_message = strip_tags(t('doc_auth.errors.general.fallback_field_level'))
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).not_to have_content(selfie_inline_error_message)

# when there is a doc auth error on one side of the ID and a liveness error

Expand Down Expand Up @@ -503,6 +515,8 @@

inline_error_message = strip_tags(t('doc_auth.errors.general.fallback_field_level'))
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).not_to have_content(selfie_inline_error_message)

# when doc auth result is "attention" and face match errors

Expand Down Expand Up @@ -532,6 +546,8 @@

inline_error_message = strip_tags(t('doc_auth.errors.general.fallback_field_level'))
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).not_to have_content(selfie_inline_error_message)

# when doc auth passes but there are both liveness errors and face match errors

Expand Down Expand Up @@ -561,6 +577,9 @@
click_try_again
expect(page).to have_current_path(idv_document_capture_path)

selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).to have_content(selfie_inline_error_message)

# when doc auth, liveness, and face match pass but PII validation fails

attach_images(
Expand Down Expand Up @@ -591,6 +610,8 @@
t('doc_auth.errors.general.multiple_front_id_failures'),
)
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).not_to have_content(selfie_inline_error_message)

# when there are both face match errors and pii errors

Expand Down Expand Up @@ -622,6 +643,8 @@
t('doc_auth.errors.general.multiple_front_id_failures'),
)
expect(page).to have_content(inline_error_message)
selfie_inline_error_message = strip_tags(t('doc_auth.errors.general.selfie_failure'))
expect(page).to have_content(selfie_inline_error_message)
end
end

Expand Down
1 change: 0 additions & 1 deletion spec/i18n_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ class BaseTask
{ key: 'doc_auth.errors.alerts.selfie_not_live', locales: %i[zh] },
{ key: 'doc_auth.errors.alerts.selfie_not_live_help_link_text', locales: %i[zh] },
{ key: 'doc_auth.errors.alerts.selfie_poor_quality', locales: %i[zh] },
{ key: 'doc_auth.errors.general.selfie_failure', locales: %i[zh] },
{ key: 'doc_auth.errors.general.selfie_failure_help_link_text', locales: %i[zh] },
{ key: 'doc_auth.headings.hybrid_handoff_selfie', locales: %i[zh] },
{ key: 'doc_auth.info.getting_started_html', locales: %i[zh] },
Expand Down