Merged
Conversation
This method is extensively tested, but I can’t find anywhere it is used. [This part](https://github.com/18F/identity-idp/blob/5b1b15e8ff5b3a8f406557eacb8a501684e2d9e0/app/services/flow/base_step.rb#L52) of the tests for the old flow state machine makes me suspect it was used to build a response for the `#call` method on FSM steps. [skip changelog]
zachmargolis
approved these changes
Apr 24, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! It was added to combine multiple responses during doc auth (separate calls for image submission from liveness etc), and to be compatible with FormResponse#merge (which maybe we could look into removing too), awesome it is no longer in use!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is extensively tested, but I can’t find anywhere it is used. This part of the tests for the old flow state machine makes me suspect it was used to build a response for the
#callmethod on FSM steps.