Skip to content

Remove deprecated GPO routes #10495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Apr 24, 2024
Merged

Remove deprecated GPO routes #10495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,10 +425,6 @@
if FeatureManagement.gpo_verification_enabled?
get '/by_mail/request_letter' => 'by_mail/request_letter#index', as: :request_letter
put '/by_mail/request_letter' => 'by_mail/request_letter#create'

# Temporary routes + redirects supporting GPO route renaming
get '/usps' => redirect('/verify/by_mail/request_letter')
put '/usps' => 'by_mail/request_letter#create'
end

get '/by_mail/letter_enqueued' => 'by_mail/letter_enqueued#show', as: :letter_enqueued
Expand Down
23 changes: 4 additions & 19 deletions spec/routing/gpo_verification_routing_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,13 @@
RSpec.describe 'GPO verification routes' do
let(:get_routes) do
%w[
verify/usps
]
end

let(:create_routes) do
%w[
verify/usps
verify/by_mail/request_letter
]
end

let(:put_routes) do
%w[
verify/usps
verify/by_mail/request_letter
]
end

Expand All @@ -38,11 +32,6 @@
to route_to(controller: 'pages', action: 'page_not_found', path: route)
end

create_routes.each do |route|
expect(post: route).
to route_to(controller: 'pages', action: 'page_not_found', path: route)
end

put_routes.each do |route|
expect(put: route).
to route_to(controller: 'pages', action: 'page_not_found', path: route)
Expand All @@ -59,15 +48,11 @@

it 'routes to endpoints controlled by feature flag' do
get_routes.each do |route|
expect(get: route).to be_routable
end

create_routes.each do |route|
expect(post: route).to be_routable
Copy link
Copy Markdown
Contributor Author

@aduth aduth Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be_routable is true even if the route directs to a 404, so this wasn't really testing anything before. We don't have POST routes for these paths.

expect(get: route).to route_to(controller: 'idv/by_mail/request_letter', action: 'index')
end

put_routes.each do |route|
expect(put: route).to be_routable
expect(put: route).to route_to(controller: 'idv/by_mail/request_letter', action: 'create')
end
end
end
Expand Down