Merged
Conversation
- Only used in one place, easy to check response status changelog: Internal, Source code, Remove dependency on subprocess gem
aduth
approved these changes
Apr 24, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍
I was trying to find if there was any meaningful difference between system and Process (what subprocess uses internally), though I'm assuming it's functionally equivalent for how we're using it here.
Sgtpluck
approved these changes
Apr 24, 2024
Contributor
Author
The difference was that Subprocess throws an error on failure instead of returning false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only used in one place, easy to check response status
Kernel#system returns true/false, we can just check that and throw an error as needed