Merged
Conversation
- Switch Proofing::Aamva::Applicant to be a Struct changelog: Internal, Source code, Remove dependency on hashie gem
zachmargolis
commented
Apr 23, 2024
| module Proofing | ||
| module Aamva | ||
| class Applicant < Hashie::Mash | ||
| Applicant = Struct.new( |
Contributor
Author
There was a problem hiding this comment.
Another option is to use Data.define for read-only versions of these objects. However, the specs seemed to rely on hash key access, which structs provide, but data objects do not
Contributor
Author
There was a problem hiding this comment.
Also open to using RedactedStruct if we think there's risk of these being copy-pasted in the console too
Contributor
There was a problem hiding this comment.
I vote for RedactedStruct, on general paranioa principles, but I don't feel strongly about it.
jmax-gsa
approved these changes
Apr 23, 2024
Contributor
jmax-gsa
left a comment
jmax-gsa
left a comment
There was a problem hiding this comment.
LGTM
Thanks; it's nice to see a gem removed.
| module Proofing | ||
| module Aamva | ||
| class Applicant < Hashie::Mash | ||
| Applicant = Struct.new( |
Contributor
There was a problem hiding this comment.
I vote for RedactedStruct, on general paranioa principles, but I don't feel strongly about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the one usage of
hashiegem was insideProofing::Aamva::Applicant. I don't think the gem is that critical, and can be replaced with standard library things, so giving this a shot!Happy to clsoe if we don't need it