Conversation
Comment on lines
+391
to
+395
| , coalesce(properties.event_properties.fraud_review_pending, 0) AS fraud_review_pending | ||
| , coalesce(properties.event_properties.gpo_verification_pending, 0) AS gpo_verification_pending | ||
| , coalesce(properties.event_properties.in_person_verification_pending, 0) AS in_person_verification_pending | ||
| , ispresent(properties.event_properties.deactivation_reason) AS has_other_deactivation_reason | ||
| , !fraud_review_pending and !gpo_verification_pending and !in_person_verification_pending and !has_other_deactivation_reason AS identity_verified |
Contributor
There was a problem hiding this comment.
can you update the specs with examples of a few of these fields coming back in the response?
Contributor
Author
There was a problem hiding this comment.
Done. Thanks for the reminder!
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Apr 23, 2024
Sgtpluck
approved these changes
Apr 23, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: Internal, Data Reporting, Fix Drop Off Report
mmagsa
force-pushed
the
ma/fix_dropoff_report
branch
from
ab8b48a to
361ff5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13127
🛠 Summary of changes
Adds a number of fields required to calculate
Workflow Complete - Total Pendingto the report query.