Skip to content

Remove nondeterministic DB migration code #10473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Apr 20, 2024
Merged

Remove nondeterministic DB migration code #10473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions db/primary_migrate/20210614145845_add_email_name_id_format_to_service_providers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,5 @@ class AddEmailNameIdFormatToServiceProviders < ActiveRecord::Migration[6.1]
def change
add_column :service_providers, :email_nameid_format_allowed, :boolean
change_column_default :service_providers, :email_nameid_format_allowed, from: nil, to: false

reversible do |dir|
dir.up do
if IdentityConfig.store.respond_to?(:issuers_with_email_nameid_format)
issuers = IdentityConfig.store.issuers_with_email_nameid_format
unless issuers.empty?
query = <<~SQL
UPDATE service_providers
SET email_nameid_format_allowed = 't'
WHERE issuer in (#{issuers.map { |i| "'#{i}'" }.join(', ')})
SQL
ActiveRecord::Base.connection.execute(query)
end
end
end
end
end
end