LG-12712 Use phone fingerprint as rate limit key for phone confirmation#10459

Closed

kevinsmaster5 wants to merge 27 commits intomainfrom

kmas-lg-12712-phone-fingerprint-rate-limit

Commits on May 1, 2024

changelog: Internal, Fraud Prevention, Use phone fingerprint as rate limit key for phone confirmation
kevinsmaster5
committed
add submission limit check to phone setup. config values
kevinsmaster5
committed
move check invocation to before_action
kevinsmaster5
committed
fingerprint submissions limit to 20
kevinsmaster5
committed
check for nil phone value before running limit check
kevinsmaster5
committed
explicitly pass parsed phone as string
kevinsmaster5
committed
added check for blank entry and fix for nil string errors that spec surfaced, better lockout
kevinsmaster5
committed
add test to lock out user exceeding phone submissions
kevinsmaster5
committed
expand on phone submission test with additional user and locked attribute
kevinsmaster5
committed
refactor setup controller to remove logout. update lockout time in application config
kevinsmaster5
committed
redirect failed phone setup to account
kevinsmaster5
committed
leverages OtpRateLimiter and modifies it to accept another limiter
kevinsmaster5
committed
add limit_type to otp rate limiter spec
kevinsmaster5
committed
add limit_type to sign in and send phone confirmation spec
kevinsmaster5
committed
retreat changes after commit 0550b52
kevinsmaster5
committed
rename fingerprint rate limit type
kevinsmaster5
committed
corrects test for user2 2F lockout
kevinsmaster5
committed
standardize rate limiter name, remove no-longer needed returns, redirect to phone setup and remove 2f lockout
kevinsmaster5
committed
move validation to NewPhoneForm
kevinsmaster5
committed
rename error to match actual form symbol
kevinsmaster5
committed
rebase to incorporate phone_setup changes. add to error handling from FromResponse
kevinsmaster5
committed
revise spec to account for phone setup controller ability to show errors
kevinsmaster5
committed
revises error message handling and respective test
kevinsmaster5
committed
revert change to phone setup controller spec
kevinsmaster5
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-12712 Use phone fingerprint as rate limit key for phone confirmation#10459

LG-12712 Use phone fingerprint as rate limit key for phone confirmation#10459
kevinsmaster5 wants to merge 27 commits intomainfrom
kmas-lg-12712-phone-fingerprint-rate-limit

Commits on May 1, 2024

changelog: Internal, Fraud Prevention, Use phone fingerprint as rate limit key for phone confirmation

add submission limit check to phone setup. config values

move check invocation to before_action

fingerprint submissions limit to 20

check for nil phone value before running limit check

explicitly pass parsed phone as string

added check for blank entry and fix for nil string errors that spec surfaced, better lockout

add test to lock out user exceeding phone submissions

expand on phone submission test with additional user and locked attribute

refactor setup controller to remove logout. update lockout time in application config

redirect failed phone setup to account

leverages OtpRateLimiter and modifies it to accept another limiter

add limit_type to otp rate limiter spec

add limit_type to sign in and send phone confirmation spec

retreat changes after commit 0550b52

rename fingerprint rate limit type

corrects test for user2 2F lockout

standardize rate limiter name, remove no-longer needed returns, redirect to phone setup and remove 2f lockout

move validation to NewPhoneForm

rename error to match actual form symbol

rebase to incorporate phone_setup changes. add to error handling from FromResponse

revise spec to account for phone setup controller ability to show errors

revises error message handling and respective test

revert change to phone setup controller spec

Commits on May 2, 2024

fix error messaging to flash. add testing for error display

remove unneeded symbol from first_error_message

cleanup and optimize phone setup spec, downgrade instance variable in phone form