Skip to content

LG-12178: new event name of idv_selfie_image_clicked and captureAttempts#10438

Merged
dawei-nava merged 7 commits intomainfrom
dwang/LG-12178_selfie_image_click
Apr 17, 2024
Merged

LG-12178: new event name of idv_selfie_image_clicked and captureAttempts#10438
dawei-nava merged 7 commits intomainfrom
dwang/LG-12178_selfie_image_click

Conversation

@dawei-nava
Copy link
Contributor

@dawei-nava dawei-nava commented Apr 15, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12178

🛠 Summary of changes

Use new style of event name(idv_selfie_image_clicked) and log captureAttempts for this event.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1: login with sp with selfie requirement
  • Step 2: Proceed to doc auth remotely
  • Step 3: Click selfie to open capturing camera
  • Step 4: Verify the event contains captureAttempts

…pts.

changelog: Internal, Doc Auth, Update analytics event for selfie image clicked.
@dawei-nava dawei-nava marked this pull request as ready for review April 16, 2024 14:03
Copy link
Contributor

@charleyf charleyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the log name change worked ✔️ I'm not seeing the captureAttempts property on either Frontend: IdV: back image clicked. I'm also not seeing the idv_selfie_image_clicked ever happening?

source: 'upload',
isDrop: false,
liveness_checking_required: false,
captureAttempts: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is enough to test that the idv_selfie_image_clicked is also coming through with the captureAttempts property? Double checking because the only name I see when we're testing captureAttempts is 'IdV: test image clicked'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to include - here are some logs from make watch_events

logs.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charleyf , you are right idv_selfie_image_clicked not logged, due to event name mismatch. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charleyf, ok the card mentioned nothing about front or back clicked, added captureAttempts in analytics_event for them.

@amirbey amirbey self-requested a review April 17, 2024 14:53
Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@charleyf charleyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Dawei. Here's my logs from some testing today, they look correct to me.

2024-04-17-event-logs.json

@dawei-nava dawei-nava merged commit dde6912 into main Apr 17, 2024
@dawei-nava dawei-nava deleted the dwang/LG-12178_selfie_image_click branch April 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants