LG-12178: new event name of idv_selfie_image_clicked and captureAttempts#10438
LG-12178: new event name of idv_selfie_image_clicked and captureAttempts#10438dawei-nava merged 7 commits intomainfrom
Conversation
…pts. changelog: Internal, Doc Auth, Update analytics event for selfie image clicked.
charleyf
left a comment
There was a problem hiding this comment.
Looks like the log name change worked ✔️ I'm not seeing the captureAttempts property on either Frontend: IdV: back image clicked. I'm also not seeing the idv_selfie_image_clicked ever happening?
| source: 'upload', | ||
| isDrop: false, | ||
| liveness_checking_required: false, | ||
| captureAttempts: 1, |
There was a problem hiding this comment.
I think that this is enough to test that the idv_selfie_image_clicked is also coming through with the captureAttempts property? Double checking because the only name I see when we're testing captureAttempts is 'IdV: test image clicked'.
There was a problem hiding this comment.
Forgot to include - here are some logs from make watch_events
There was a problem hiding this comment.
@charleyf , you are right idv_selfie_image_clicked not logged, due to event name mismatch. 👍
There was a problem hiding this comment.
@charleyf, ok the card mentioned nothing about front or back clicked, added captureAttempts in analytics_event for them.
charleyf
left a comment
There was a problem hiding this comment.
Looks good! Thanks Dawei. Here's my logs from some testing today, they look correct to me.
🎫 Ticket
Link to the relevant ticket:
LG-12178
🛠 Summary of changes
Use new style of event name(idv_selfie_image_clicked) and log
captureAttemptsfor this event.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
captureAttempts