Conversation
Also the null sp session
changelog: Internal,code cleanup,Renamed various `selfie` methods to `biometric_comparison`, because that's what we really mean.
jmax-gsa
force-pushed
the
jmax/LG-13032-rename-selfie-to-biometric-comparison-where-appropriate
branch
from
cdcf7b5 to
3617930
Compare
jmhooper
approved these changes
Apr 16, 2024
| redirect_to idv_url if current_user.identity_not_verified? | ||
| end | ||
|
|
||
| def confirm_selfie_captured |
Contributor
There was a problem hiding this comment.
👍
This should be fine to be removed since the selfie capture biometric comparison requirement is enforced by OpenidConnect::AuthorizationsController and SamlIdpController.
…parison-where-appropriate
jmax-gsa
deleted the
jmax/LG-13032-rename-selfie-to-biometric-comparison-where-appropriate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13032
🛠 Summary of changes
Renamed various methods which had
selfiein their name tobiometric_comparisonequivalants. Specifically:IdvSessionConcern#user_needs_selfie?->#user_needs_biometric_comparison?OpenidConnect::AuthorizationController#selfie_needed?->#biometric_comparison_needed?SamlIdpController#selfie_needed?->#biometric_comparison_needed?SignUp::CompletionsController#confirm_selfie_captured-> removedSignUp::CompletionsController#selfie_required?-> removedServiceProviderSession#selfie_required?->#biometric_comparison_required?NullServiceProviderSession#selfie_required?->#biometric_comparison_required?User#identity_verified_with_selfie?->#identity_verified_with_biometric_comparison?📜 Testing Plan