Skip to content

Add user remember_created_at as ignored column#10431

Merged
aduth merged 1 commit intomainfrom
aduth-users-remember-created-at-ignore
Apr 15, 2024
Merged

Add user remember_created_at as ignored column#10431
aduth merged 1 commit intomainfrom
aduth-users-remember-created-at-ignore

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 15, 2024

🛠 Summary of changes

Marks remember_created_at on the User model as ignored, as a prerequisite to removing the column in #10429.

See: #10429 (review)

📜 Testing Plan

Verify that selecting all fields from a user does not produce a query including remember_created_at:

$ rails c
> User.first
# Observe that the logged SQL query does not include `remember_created_at`

changelog: Internal, Database, Remove unused column from users table
@aduth aduth merged commit 616d770 into main Apr 15, 2024
@aduth aduth deleted the aduth-users-remember-created-at-ignore branch April 15, 2024 14:10
@mitchellhenke mitchellhenke mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants