Remove "fast" versions of setup and test tasks#10424
Merged
Conversation
changelog: Internal, Local Development, Remove "fast" versions of setup and test tasks
mitchellhenke
approved these changes
Apr 12, 2024
zachmargolis
approved these changes
Apr 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes "fast" alternatives to
make testandmake setup, i.e.make fast_testandmake fast_setup.As a substitute, added a new paragraph to README.md encouraging running tests for individual files and folders.
Why?
fast_setup, it's unclear that it actually works, and has likely fallen out of sync withbin/setupfast_test, while this may have been helpful when accessibility tests were some of the only tests using ChromeDriver, there is now many more tests using the headless browser and therefore "fast_test" is not really very fast anyways.📜 Testing Plan
Verify
make fast_testandmake fast_setuperror due to removed task code.