LG-12294: Fix asynchronous email delivery for aggregated sign-in email#10421
Merged
LG-12294: Fix asynchronous email delivery for aggregated sign-in email#10421
Conversation
changelog: Upcoming Features, Sign In, Send single aggregated email notification for new device sign-in
aduth
changed the title
zachmargolis
approved these changes
Apr 12, 2024
mitchellhenke
approved these changes
Apr 12, 2024
| 'sign_in_after_2fa', | ||
| ], | ||
| ).order(:created_at).includes(:device) | ||
| ).order(:created_at).includes(:device).to_a |
Contributor
There was a problem hiding this comment.
Not worth blocking this fix, but I think we could consider a limit here on the outside chance that there are an incredible number of events.
Contributor
Author
There was a problem hiding this comment.
I'll follow-up with you separately on this. I agree with the general premise, but I'd have some concern about limiting what we show here.
Contributor
There was a problem hiding this comment.
maybe if there are more we just get the count of the rest and say something like "and 15 more devices"
mitchellhenke
approved these changes
Apr 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Supplemental fix for LG-12294
🛠 Summary of changes
Fixes an issue where asynchronous delivery of aggregated new device sign-in email notifications raises an error, due to non-serializable arguments.
Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1712932922568999
📜 Testing Plan
deliver_mail_async: truetoconfig/application.yml