Skip to content

Split print styles to separate stylesheet #10419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Apr 12, 2024
Merged

Split print styles to separate stylesheet #10419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/assets/stylesheets/application.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@
@forward 'design-system-waiting-room';
@forward 'components';
@forward 'utilities';
@forward 'print';
7 changes: 7 additions & 0 deletions app/assets/stylesheets/print.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
nav,
footer,
.usa-button,
.usa-radio__input--bordered,
.usa-checkbox__input--bordered {
display: none;
}
9 changes: 0 additions & 9 deletions app/assets/stylesheets/print.scss
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion app/views/layouts/base.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
<%= preload_link_tag font_url('public-sans/PublicSans-Bold.woff2') %>
<%= preload_link_tag font_url('public-sans/PublicSans-Regular.woff2') %>
<%= render_stylesheet_once_tags %>
<%= stylesheet_link_tag 'application', media: 'all' %>
<%= stylesheet_link_tag 'application' %>
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make a difference to keep the media: 'all' or is that basically the default value?

Copy link
Copy Markdown
Contributor Author

@aduth aduth Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's redundant. I couldn't find anything which explicitly states that it's the default, but this documents the distinction between print and screen, and all as matching the union. I assume we meant it as applying the same as if it weren't applied at all.

https://drafts.csswg.org/mediaqueries/#media-types

<%= stylesheet_link_tag 'print', media: :print, preload_links_header: false %>
<%= csrf_meta_tags %>

<%= favicon_link_tag(
Expand Down