Skip to content

LG-12829: add conditional links for selfie help center articles #10415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amirbey merged 4 commits into from
Apr 15, 2024
Merged

LG-12829: add conditional links for selfie help center articles #10415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5637c4f
add conditional links for selfie help center articles
amirbey Apr 11, 2024
7ce2a31
add fr and es translation
amirbey Apr 11, 2024
852af80
use the hash attr in URL to implement the anchor onthe help page
amirbey Apr 12, 2024
70f69b1
happy linting
amirbey Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion app/javascript/packages/document-capture/components/unknown-error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,22 @@ function UnknownError({
);
}
if ((isFailedSelfieLivenessOrQuality || isFailedSelfie) && err) {
let selfieHelpCenterLinkText = t('doc_auth.errors.general.selfie_failure_help_link_text');
const helpCenterURL = new URL(helpCenterLink);
if (isFailedSelfieLivenessOrQuality) {
helpCenterURL.hash = 'how-to-add-a-photo-of-your-face-to-help-verify-your-id';
selfieHelpCenterLinkText = t('doc_auth.errors.alerts.selfie_not_live_help_link_text');
}
return (
<>
<p>{err.message}</p>
<p>
{err.message}{' '}
{altIsFailedSelfieDontIncludeAttempts && (
<Link isExternal isNewTab href={helpCenterURL.toString()}>
{selfieHelpCenterLinkText}
</Link>
)}
</p>
<p>
{!altIsFailedSelfieDontIncludeAttempts && (
<HtmlTextWithStrongNoWrap
Expand Down
2 changes: 2 additions & 0 deletions config/locales/doc_auth/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ en:
ref_control_number_check: We couldn’t read the control number barcode. Try taking new pictures.
selfie_not_live: Try taking a photo of yourself again. Make sure your whole face
is clear and visible in the photo.
selfie_not_live_help_link_text: Review more tips for taking a clear photo of yourself
selfie_poor_quality: 'Try taking a photo of yourself again. Make sure your whole
face is clear and visible in the photo.'
sex_check: We couldn’t read the sex on your ID. Try taking new pictures.
Expand Down Expand Up @@ -87,6 +88,7 @@ en:
no_liveness: Try taking new pictures.
selfie_failure: Try taking your photos again. Make sure all of your photos are
clear and in focus.
selfie_failure_help_link_text: Review more tips for taking clear photos
glare:
failed_short: Image has glare, please try again.
top_msg: We couldn’t read your ID. Your photo may have glare. Make sure that the
Expand Down
2 changes: 2 additions & 0 deletions config/locales/doc_auth/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ es:
control. Intente tomar nuevas fotografías.
selfie_not_live: Intente tomar de nuevo una foto de usted. Asegúrese de que su
rostro se vea claramente en la foto.
selfie_not_live_help_link_text: Consulte más consejos para tomar una foto clara de su rostro
selfie_poor_quality: 'Intente tomar de nuevo una foto de usted. Asegúrese de que
su rostro se vea claramente en la foto.'
sex_check: No pudimos leer el sexo en su documento de identidad. Intente tomar
Expand Down Expand Up @@ -110,6 +111,7 @@ es:
no_liveness: Intente tomar nuevas fotografías.
selfie_failure: Intente tomar de nuevo sus fotos. Asegúrese de que sus fotos
estén claras y enfocadas.
selfie_failure_help_link_text: Consulte más consejos para tomar fotos claras
glare:
failed_short: Hay reflejos en la imagen, por favor inténtelo de nuevo.
top_msg: No pudimos leer su identificación. Es posible que su foto tenga
Expand Down
2 changes: 2 additions & 0 deletions config/locales/doc_auth/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ fr:
selfie_not_live: Essayez de prendre une nouvelle photo de vous-même.
Assurez-vous que l’ensemble de votre visage soit clair et visible sur
la photo.
selfie_not_live_help_link_text: Consultez plus de conseils pour prendre une photo claire de vous-même
selfie_poor_quality: 'Essayez de prendre une nouvelle photo de vous-même.
Assurez-vous que l’ensemble de votre visage soit clair et visible sur
la photo.'
Expand Down Expand Up @@ -117,6 +118,7 @@ fr:
no_liveness: Essayez de prendre de nouvelles photos.
selfie_failure: Essayez de prendre de nouvelles photos de vous-même. Veillez à
ce que toutes vos photos soient claires et nettes.
selfie_failure_help_link_text: Consultez plus de conseils pour prendre des photos claires
glare:
failed_short: L’image a des reflets, veuillez réessayer.
top_msg: Nous n’avons pas pu lire votre pièce d’identité. Votre photo peut avoir
Expand Down