Update cssbundling-rails to resolve redundant Yarn install#10412
Merged
Conversation
changelog: Internal, Build Tooling, Update cssbundling-rails to resolve redundant Yarn install
mitchellhenke
approved these changes
Apr 11, 2024
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
cssbundling-railsgem dependency to the latest version, from 1.0.0 to 1.4.0.This resolves an issue where
yarn installwould be called redundantly during deployments and in continuous integration during theassets:precompiletask. We intend to skip Yarn install during this task in both continuous integration (source) and deploys (source) since it is done as part of a previous step (source, source). However, bothjsbundling-railsandcssbundling-railsboth include a built-inyarn install, and while the environment variable was enough to prevent the install injsbundling-rails, it was not supported as of the version ofcssbundling-railswe had installed previously. This was identified via troubleshooting at rails/jsbundling-rails#150 (comment), and is supported as ofcssbundling-rails@1.3.0.📜 Testing Plan
SKIP_YARN_INSTALL=true rails assets:precompileyarn runand notyarn install