Merged
Conversation
Contributor
zachmargolis
commented
Apr 11, 2024
zachmargolis
commented
- Code that leveraged this never landed on main (USPS Location Caching & Fallback Proof of Concept #7790)
- Code that leveraged this never landed on main changelog: Internal, Source code, Remove PostGIS references
night-jellyfish
approved these changes
Apr 11, 2024
Contributor
night-jellyfish
left a comment
night-jellyfish
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up, including the documentation!
aduth
reviewed
Apr 11, 2024
Contributor
There was a problem hiding this comment.
Just to clarify, we don't need a new migration to disable the extension?
Contributor
Author
There was a problem hiding this comment.
ah whoops I made one but forgot to commit it 🤦 PR incoming
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.