Merged
Conversation
changelog: Internal, SAML, bump to latest saml-idp version
zachmargolis
approved these changes
Apr 9, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM this shouldn't be strictly necessary since the diff only includes changes internal to the gem, so the IDP behavior shoudn't change
Contributor
Author
|
Not sure what you mean by "shouldn't be strictly necessary". Is the PR not needed? |
Contributor
The IDP doesn't benefit from this (because there are no functional changes) so it's not needed but it is a good practice to stay at the newest versoin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, SAML, bump to latest saml-idp version