Skip to content

Move logo.png into email images directory#10389

Merged
aduth merged 1 commit intomainfrom
aduth-logo-png-email
Apr 9, 2024
Merged

Move logo.png into email images directory#10389
aduth merged 1 commit intomainfrom
aduth-logo-png-email

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 9, 2024

🛠 Summary of changes

Moves logo.png from app/assets/images to app/assets/images/email.

Why?

  • The only reason to use this image over logo.svg (or most any illustration .png vs. a .svg equivalent) is in the context of email
    • Avoid potential developer confusion leading to the incorrect image being used
    • Consolidate .png within the email directory, which includes README.md explaining the purpose those images

📜 Testing Plan

Verify no regression in the appearance of emails.

(See logo usage at top of email and above barcode)

changelog: Internal, File Structure, Consolidate raster images into email assets directory
@aduth aduth merged commit e793b76 into main Apr 9, 2024
@aduth aduth deleted the aduth-logo-png-email branch April 9, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants