-
Notifications
You must be signed in to change notification settings - Fork 166
LG-12103 Embed Styles into Login Button Lookbook Component #10387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d4878ce
add inline styles to the component
nprimak d2d7185
add as style property
nprimak 18af67d
insert svg into html
nprimak 57913e8
Add changelog
nprimak 6441a99
fix lint errors and update spec
nprimak a2a8f24
Update app/components/login_button_component.html.erb
nprimak adfac16
moved svg logic and render out of html
nprimak 9441363
Update app/components/login_button_component.rb
nprimak 91821e0
Update spec/components/previews/login_button_component_preview.rb
nprimak 32a7e1c
fix test for button text
nprimak f7429e6
change num to rem for svg size and tweak margins for alignment
nprimak e2015a1
Update app/components/login_button_component.rb
nprimak d82fe15
remove div and unecessary styles
nprimak 7e00319
run lintfix
nprimak 7a9994a
refer back to figma for proper size of svg
nprimak f5872b6
Update app/components/login_button_component.rb
nprimak ca371e4
adjust size for big (was a little small)
nprimak f462190
Update spec/components/previews/login_button_component_preview.rb
nprimak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: hooray for cleanup!
I always like to see negative margins get deprecated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!