Remove code related to document capture exit survey#10381
Merged
Conversation
zachmargolis
approved these changes
Apr 23, 2024
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
so much removed!!! especially all the react form components
changelog: Internal, Code Quality, Remove unused code related to disabled survey feature
aduth
force-pushed
the
aduth-remove-doc-auth-exit-survey
branch
from
93d6739 to
8444f9c
Compare
Contributor
Author
That's part of the motivation here, since I'm hoping to shift some more styles into ViewComponent per-component stylesheets, but the existence of these React components complicates that 😅 |
aduth
force-pushed
the
aduth-remove-doc-auth-exit-survey
branch
from
3b4d718 to
8444f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes code related to an unused survey feature in document capture.
See related Slack discussion: https://gsa-tts.slack.com/archives/C05HSH9RQ57/p1712609020635899
📜 Testing Plan
Build should pass.
Validate that you can pass document capture successfully, including exiting and returning to service provider. This should be a no-op from
mainsince the feature is disabled everywhere.