Merged
Conversation
night-jellyfish
requested review from
a team,
amirbey,
charleyf and
dawei-nava
and removed request for
a team and
charleyf
eileen-nava
approved these changes
Apr 9, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. 🙏🏻
night-jellyfish
force-pushed
the
brittany/prep-lg-12994-refactor-test-setup
branch
from
3eed55f to
0313cb5
Compare
added 2 commits
April 9, 2024 10:43
I will be adding new tests here and found that we had the selfie test setup twice. In github this ends up looking like a big change since I have to change indentation, so I wanted to do it as a separate PR. [skip changelog]
night-jellyfish
force-pushed
the
brittany/prep-lg-12994-refactor-test-setup
branch
from
0313cb5 to
79afd87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Prep for LG-12994
🛠 Summary of changes
I will be adding new tests here as a part of this ticket, and found that we had the following selfie test setup twice:
This change removes one of them.
I also:
allow_browser_log: trueup the chain for tests to continue to pass.In github this ends up looking like a big change since I have to change indentation, so I wanted to do it as a separate PR. That way when adding tests what is being changed will be more clear.
📜 Testing Plan
All automated tests should continue to pass.
[skip changelog]