Merged
Conversation
changelog: Internal, Build Tooling, Fix Sass compilation rebuild after error
zachmargolis
approved these changes
Apr 5, 2024
Contributor
Author
See sass/sass#3830 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes
@18f/identity-build-sassto rebuild stylesheets as expected after saving a file that had previously triggered an error.This relied on parsing a stack trace produced by Sass. It appears that this stack trace was updated to produce paths relative from the compiler executable.
For future consideration:
sass/embedded-host-nodeto provide full compilation result in an error. This is related to Provide a callback for when a file is being loaded, a way to provide an always used loader or an Watch option sass/embedded-host-node#190 . A failed compilation includesloadedUrls, but there's no way to get at these since the failed result raises an error without the full result object.📜 Testing Plan
yarn build-sass app/components/click_observer_component.scss --watch --verboseapp/components/click_observer_component.scssto cause an error, e.g. removing a curly braceapp/components/click_observer_component.scssto fix error