Update disavowed event lookup to load one record#10372
Merged
Conversation
changelog: Internal, Database, Optimize event disavowal query to load single record into memory
jmhooper
approved these changes
Apr 5, 2024
zachmargolis
approved these changes
Apr 5, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
EventDisavowal::FindDisavowedEvent#eventto avoid loading all events matching token fingerprints.This is the result of a discussion with @jmhooper stemming from surprise around performance characteristics noted in #2855. While
#firstwould still be advisable to avoid here due to built-in ordering ("if no order is defined it will order by primary key"),#find_bywill locate at most one record without imposing any order.#takewould have also worked.The previous implementation was likely fine enough since the logic producing fingerprints would likely only ever produce 0 or 1 database results, but these revisions are simpler and more semantic, and should hopefully avoid future confusion around unoptimized
LIMIT 1queries.📜 Testing Plan
Existing tests provide coverage for (a) missing, (b) matched, (c) matched old key. Verify they pass: