Skip to content

Fix manifest cache for local JavaScript feature tests #10365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Apr 4, 2024
Merged

Fix manifest cache for local JavaScript feature tests #10365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,13 @@ class Analytics
# rubocop:enable Style/GlobalVars
# rubocop:disable Rails/Output
print ' Bundling JavaScript and stylesheets... '
system 'WEBPACK_PORT= yarn concurrently "yarn:build:*" > /dev/null 2>&1'
Copy link
Copy Markdown
Contributor Author

@aduth aduth Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the environment variable isn't related to the fix, but was part of my troubleshooting. I don't think it's doing anything since the value is "empty" regardless whether it's provided or not.

system 'yarn concurrently "yarn:build:*" > /dev/null 2>&1'
puts '✨ Done!'
# rubocop:enable Rails/Output

# The JavaScript assets manifest is cached by the application. Since the preceding build will
# write a new manifest, instruct the application to refresh the cache from disk.
Rails.application.config.asset_sources.load_manifest
end
end

Expand Down