Check duplicate element IDs in accessibility tests#10362
Merged
Conversation
Section 508 is redundant with WCAG 2 AA: "The Revised 508 Standards incorporate by reference the WCAG 2.0 Level AA Success Criteria, and apply the WCAG 2.0 Level AA success criteria and conformance requirements to both web and non-web electronic content." https://www.section508.gov/develop/applicability-conformance/
changelog: Internal, Automated Testing, Check duplicate element IDs in accessibility tests
10 tasks
mitchellhenke
approved these changes
Apr 4, 2024
JackRyan1989
approved these changes
Apr 4, 2024
Contributor
JackRyan1989
left a comment
JackRyan1989
left a comment
There was a problem hiding this comment.
Nice! catches the dupe id issue on the how to verify page, so you may need to skip that test for now unless you want me to push up a fix prior to merging this.
This reverts commit 12ae6e4.
The intent of the previous code was "latest 2.x", meaning 2.2 currently. In reality, "wcag2aa" means "2.0" specifically. Ref: https://github.com/dequelabs/axe-core/blob/master/doc/API.md#axe-core-tags
Contributor
Author
I pushed a fix in b6a35a0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Enhances existing accessibility checks to verify that no duplicate IDs exist.
Related WCAG Failure: F77: Failure of Success Criterion 4.1.1 due to duplicate values of type ID
Previous discussion: #10289 (comment)
Ideally this would be something our existing Axe-based testing tools could identify (Axe even has an article for a related rule), but I could not cause an issue to be flagged in my testing with either the Ruby-based Axe tool nor the Chrome browser extension.
📜 Testing Plan
Verify that build with commit including demonstrated failure fails (12ae6e4), and passes without.
(TBD if there's any existing issues that will need to be fixed)